fix: migrate to Blocktank client v2 #2350
Draft
+30
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@synonymdev/[email protected] |
limpbrains
commented
Nov 14, 2024
| @@ -41,7 +41,7 @@ const ReceiveConnect = ({ | |||
| const { maxChannelSizeSat } = blocktank.options; | |||
| const minChannelSize = Math.round(amount * 2.5); | |||
| const maxChannelSize = Math.round(maxChannelSizeSat / 2); | |||
| const channelSize = Math.max(minChannelSize, maxChannelSize); | |||
| const channelSize = Math.min(minChannelSize, maxChannelSize); | |||
There was a problem hiding this comment.
It is a mistake here. minChannelSize = amount * 2.5 and it can be bigger than maxChannelSize
Looks like it was changed at 2a6b1fb by mistake
There was a problem hiding this comment.
Maybe it should be ?
const channelSize = min(max(amount * 2.5, maxChannelSizeSat / 2), maxChannelSizeSat);
There was a problem hiding this comment.
yeah looks wrong, but I think in that case BT will return an error. I'd say leave it for now. I have a task to update these values to the new policy here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate to the new blocktank http client v2
Linked Issues/Tasks
Type of change
Refactoring
Tests
No test